[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[cp-patches] FYI: fixlet for AbstractButton
From: |
Roman Kennke |
Subject: |
[cp-patches] FYI: fixlet for AbstractButton |
Date: |
Wed, 06 Jul 2005 14:24:42 +0200 |
User-agent: |
Mozilla Thunderbird 1.0.2 (X11/20050317) |
I see that I actually forgot to commit the patch that I sent yesterday
concerning the opaque property thing in the buttons. Which is good,
because otherwise I would have to revert this now. I found the real
reason for the bugs that I've seen. My application here sets the
property contentAreaFilled in a JToggleButton, which effectivly makes it
opaque. I've written a mauve test that seconds that, so I commit this
small patch.
2005-07-06 Roman Kennke <address@hidden>
* javax/swing/AbstractButton.java
(setContentAreaFilled): Set the opaque property here.
/Roman
Index: javax/swing/AbstractButton.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/AbstractButton.java,v
retrieving revision 1.33
diff -u -r1.33 AbstractButton.java
--- javax/swing/AbstractButton.java 2 Jul 2005 20:32:46 -0000 1.33
+++ javax/swing/AbstractButton.java 6 Jul 2005 12:18:53 -0000
@@ -1881,8 +1881,9 @@
boolean old = contentAreaFilled;
contentAreaFilled = b;
firePropertyChange(CONTENT_AREA_FILLED_CHANGED_PROPERTY, old, b);
- revalidate();
- repaint();
+ // The JDK sets the opaque property to the value of the contentAreaFilled
+ // property, so should we do.
+ setOpaque(b);
}
/**
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [cp-patches] FYI: fixlet for AbstractButton,
Roman Kennke <=