[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[cp-patches] FYI: 2 JMenu related patches
From: |
Anthony Balkissoon |
Subject: |
[cp-patches] FYI: 2 JMenu related patches |
Date: |
Mon, 11 Jul 2005 14:30:19 -0400 |
I committed the patch I sent to the list earlier today which fixes bug
13683.
Second patch fixes BasicMenuUI's handling of MouseEntered events. To
comply with the JDK a top level menu shouldn't be selected upon a mouse
entered event unless there was a previously selected menu in the same
menubar and that menu had its popup menu visible. Previously we were
selecting it whether or not the popup menu was visible. This has been
committed.
Patches attached.
2005-07-11 Anthony Balkissoon <address@hidden>
* javax/swing/plaf/basic/BasicMenuUI.java:
(MouseInputHandler.mouseEntered): Added check: if a different menu in
the menubar was selected, we don't select this one unless the old one
had its popup menu showing. This complies with the reference
implementation.
2005-07-11 Anthony Balkissoon <address@hidden>
* javax/swing/JMenu.java:
(setSelectedHelper): new method.
(setSelected): Code moved to setSelectedHelper. Calls
setSelectedHelper(selected,true,false) which doesn't expand the popup
menu and works whether the menu is enabled or not.
(menuSelectionChanged): Changed call to setSelected(changed) to
setSelectedHelper(changed,isEnabled(),true) which does expand the
popup menu, but only if the menu is enabled.
-Tony
JMenuSetSelected.diff
Description: Text Data
JMenuMouseEnteredSelection.diff
Description: Text Data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [cp-patches] FYI: 2 JMenu related patches,
Anthony Balkissoon <=