Re: [cp-patches] Logging fixes

[Mark Wielaard]

Hi,

On Wed, 2005-07-13 at 21:54 +0200, Guilhem Lavaux wrote:
> 2005-07-13  Guilhem Lavaux  <address@hidden>
> 
>         * java/util/logging/Logger.java
>         (resetLogger): Remove all handlers from the handler list.
> 
>         * java/util/logging/LogManager.java
>         (reset): Call resetLogger() too.
>         (readConfiguration): Call reset() and use the system class
>       loader to resolve classes.

Better would be to have a mechanism for defining the class loader to
load the handlers (or use the Thread context class loader to do it). But
this is probably the best we can do given the current interface. And it
seems compatible with other implementations.

> --- java/util/logging/LogManager.java   2 Jul 2005 20:32:44 -0000       1.14
> +++ java/util/logging/LogManager.java   13 Jul 2005 18:43:41 -0000
> @@ -443,6 +443,7 @@
>           {
>             logger = (Logger) ref.get();
>  
> +           logger.resetLogger();
>             if (logger == null)
>               iter.remove();
>             else if (logger != rootLogger)

logger can be null here since it comes from a WeakReference, so put the
resetLogger() call in the else branch.

> This patch fixes this PR (against kaffe):
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=307983

Could this be turned into a mauve test that calls readConfiguration() to
test that everything works?

Please commit this with the fixlet pointed out above.

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part