[cp-patches] FYI: BasicOptionPane fixlet

[Roman Kennke]

I found that the JOptionPane must not have a separator component 
installed between the top and bottom JPanel. I have an application 
(using a custom L&F) here that depends on the JOptionPane only having 
two child components.

2005-07-20  Roman Kennke  <address@hidden>

       * javax/swing/plaf/basic/BasicOptionPaneUI.java
       (createSeparator): Return null here.
       (installComponents): Don't add a separator in the OptionPane.

/Roman

Index: javax/swing/plaf/basic/BasicOptionPaneUI.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicOptionPaneUI.java,v
retrieving revision 1.20
diff -u -r1.20 BasicOptionPaneUI.java
--- javax/swing/plaf/basic/BasicOptionPaneUI.java       15 Jul 2005 15:15:35 
-0000      1.20
+++ javax/swing/plaf/basic/BasicOptionPaneUI.java       20 Jul 2005 13:58:40 
-0000
@@ -910,7 +910,9 @@
    */
   protected Container createSeparator()
   {
-    return (Container) Box.createVerticalStrut(17);
+    // FIXME: Figure out what this method is supposed to return and where
+    // this should be added to the OptionPane.
+    return null;
   }
 
   /**
@@ -1115,6 +1117,10 @@
        optionPane.add(msg);
       }
 
+    // FIXME: Figure out if the separator should be inserted here or what
+    // this thing is supposed to do. Note: The JDK does NOT insert another
+    // component at this place. The JOptionPane only has two panels in it
+    // and there actually are applications that depend on this beeing so.
     Container sep = createSeparator();
     if (sep != null)
       optionPane.add(sep);