classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Re: [RFA/JDWP] ClassObjectReferenceCommandSet.java


From: Aaron Luchko
Subject: [cp-patches] Re: [RFA/JDWP] ClassObjectReferenceCommandSet.java
Date: Wed, 20 Jul 2005 14:22:04 -0400

On Wed, 2005-07-20 at 11:10 -0600, Tom Tromey wrote:
> >>>>> "Aaron" == Aaron Luchko <address@hidden> writes:
> 
> Aaron> 2005-07-12  Aaron Luchko  <address@hidden>
> Aaron>      * 
> gnu/classpath/jdwp/processor/ClassObjectReferenceCommandSet.java:
> Aaron>        Implemented the ClassObjectReference CommandSet.
> 
> This looks fine to me... one nit though.
> 
> Aaron> +            throw new NotImplementedException("Command " + command +
> Aaron> +              " not found in String Reference Command Set.");
> 
> Isn't this "Class Object", not "String"?

Oops :)

This has actually slipped into a few different CommandSets. I'll just
fix those with other future fixes.

Due to the merger it looks like I should only be committing this stuff
to classpath from now on so I've applied the patch there but not gcj.

thanks, Aaron

ChangeLog

2005-07-20  Aaron Luchko  <address@hidden>

     * gnu/classpath/jdwp/processor/ClassObjectReferenceCommandSet.java:
       Implemented the ClassObjectReference CommandSet.

Attachment: jdwpClassObject2.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]