Re: [cp-patches] [RFA/JDWP] ArrayReferenceCommandSet.java

[Tom Tromey]

>>>>> "Aaron" == Aaron Luchko <address@hidden> writes:

Aaron> There's a slightly ugly part with a big if/else in executeGetValues but
Aaron> there doesn't seem to be a way to get rid of this.

This looks really similar to some code in the Values patch.  I suggest
a static utility method somewhere that takes a class and returns the
corresponding tag.  Then the big if/else here just becomes a method
call, and the conditional tag stuff in that method in Values becomes a
single conditional write... what do you think?

Aaron> +    // Write all the values, primatives should be untagged and Objects 
must be

Should be "primitives" ... this occurs both here and I think in the
Values patch as well.

Tom