Re: [cp-patches] FYI: Some fixes and optimizations for Container

[Mark Wielaard]

Hi Roman,

On Mon, 2005-07-25 at 16:20 +0200, Roman Kennke wrote:
> -/* AWTUtilities.java -- Common utility methods for AWT and Swing.
> -   Copyright (C) 2005  Free Software Foundation, Inc.
> +/* Copyright (C) 2004 Free Software Foundation

Don't do that.
 
> -Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> -02110-1301 USA.
> +Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> +02111-1307 USA.

Please keep the new address in place everywhere.

> +  public static Rectangle calculateInsetArea(Rectangle base, Insets
> insets,
> +
> Rectangle ret)

This looks strange, did you forget a return here?
There are a couple of similar things like this in the patch.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part