Re: [cp-patches] FYI: Minor tweak to java.awt.List

[Mark Wielaard]

Hi,

On Sat, 2005-07-23 at 18:00 +0200, Sven de Marothy wrote:
> This agrees with the JDK behaviour better. And my peers expect it too.
> 
> (Whoops, accidentally commited a change to Component. Did that revert
> correctly?)

No. You committed the attached.
The first hunk seems to have been changed by Roman already.

I assume the second hunk still needs to be reverted.

--- java/awt/Component.java     25 Jul 2005 14:18:02 -0000      1.65
+++ java/awt/Component.java     26 Jul 2005 07:58:45 -0000
@@ -3430,7 +3430,7 @@
     /* Now that all the children has gotten their peers, we should
        have the event mask needed for this component and its
        lightweight subcomponents. */
-    //    peer.setEventMask(eventMask);
+    peer.setEventMask(eventMask);
     /* We do not invalidate here, but rather leave that job up to
        the peer. For efficiency, the peer can choose not to
        invalidate if it is happy with the current dimensions,

Could you do that if that is correct?

Thanks,

Mark

===================================================================
RCS file: 
/cvsroot/classpath/cvsroot/classpath/classpath/java/awt/Component.java,v
retrieving revision 1.63
retrieving revision 1.64
diff -u -r1.63 -r1.64
--- classpath/classpath/java/awt/Component.java 2005/07/22 14:33:07     1.63
+++ classpath/classpath/java/awt/Component.java 2005/07/23 15:29:48     1.64
@@ -215,7 +215,8 @@
    * Preallocated default font returned by getFont() if no font was
    * set explicitly.
    */
-  private static final Font DEFAULT_FONT = new Font ("Dialog", Font.PLAIN, 12);
+  //  private static final Font DEFAULT_FONT = new Font ("Dialog", Font.PLAIN, 
12);
+  private static final Font DEFAULT_FONT = null;
 
   // Serialized fields from the serialization spec.
 
@@ -3436,7 +3437,7 @@
     /* Now that all the children has gotten their peers, we should
        have the event mask needed for this component and its
        lightweight subcomponents. */
-    peer.setEventMask(eventMask);
+    //    peer.setEventMask(eventMask);
     /* We do not invalidate here, but rather leave that job up to
        the peer. For efficiency, the peer can choose not to
        invalidate if it is happy with the current dimensions,

signature.asc
Description: This is a digitally signed message part