Re: [cp-patches] RFC: Added methods to javax.swing.plaf.basic.BasicTreeUI

[Roman Kennke]

Hi Jan,

Jan Röhrich schrieb:
> 2005-07-31  Jan Roehrich <address@hidden>
>
>         * javax.swing.plaf.basic.BasicTreeUI: paintVerticalLine and
>         paintHorizontalLine added.
>         
> RFC only because I'm new to classpath. This are trivial changes.

Looks good. The methods should actually be used by some other method. In 
addition to this I would also check if:
- some color is set (like an UI default)
- if the BasicL&F implementations of these methods actually do something 
or leave it to subclasses to do something in these methods. I have seen 
many no-op protected methods in BasicL&F

A minor nitpick: The API comments for the @param tags should start 
lowercase. Please refer to

http://java.sun.com/j2se/javadoc/writingdoccomments/

for recommendations for writing API comments.

Besides that, please check it in.

/Roman