Re: [cp-patches] FYI: Method drawCentered add to BasicTreeUI

[Mark Wielaard]

Hi Jan,

On Mon, 2005-08-01 at 00:31 +0200, Jan Röhrich wrote:
> 2005-08-01  Jan Roehrich <address@hidden>
> 
>       * javax.swing.plaf.basic.BasicTreeUI: Method drawCentered
>       added / corrected javadoc issues in paintHorizonalLine 
>       and paintVerticalLine / fixed getRightChildIndent signature
>       (problem probably caused by copy/paste)

Thanks for working on this. Could you follow our ChangeLog style for
future entries? GNU Classpath Hacker Guide.
7.1 Documenting what changed when with ChangeLog entries
http://www.gnu.org/software/classpath/docs/hacking.html#SEC9

So for the above I would have written something like:

2005-08-01  Jan Roehrich  <address@hidden>

        * javax/swing/plaf/basic/BasicTreeUI.java
        (getRightChildIndent): Remove parameter newAmount.
        (paintVerticalLine): Updated documentation.
        (paintHorizontalLine): Likewise.
        (drawCentered): New protected method.

Sorry for nitpicking. But keeping things similar makes searching for
when something was changed by whom a lot easier.

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part