Re: [cp-patches] [RFC/JDWP] ID management

[Keith Seitz]

On Tue, 2005-08-09 at 13:23 -0700, Keith Seitz wrote:

> I am refactoring my code now and I will post a follow-up shortly.

Well, after quite a bit of refactoring and distraction, I've finally
gotten everything in the next stage of satisfied. I've checked this over
several times, and I think I've addressed people's concerns, but I've
looked it over so many times in the last two days, I might have missed
something, so any extra eyes are appreciated.

Note that this is now considered a reference implementation to go into
vm/reference/gnu/classpath/jdwp. I have done similar refactoring for
what used to be called "IVirtualMachine" (which you'll see in Aaron's
processor patches). I will submit patches for those once this is
approved.

I have only two nits/concerns with this patch. First, VMIdManager
defines two relatively non-trivial inner classes. Alas, without
checking-in multiple files to vm/reference/gnu/classpath/jdwp, I am
forced to throw it all into VMIdManager. (Okay, I don't think it's all
really that bad, but I would have preferred to do it otherwise.)

Second, I'm not particularly fond of how this class gets instantiated.
But since it really is a separate facility from the VM-specific
functions in VMVirtualMachine (yet to be posted), I have decided
(reluctantly) to follow the functional distinction. I've removed
Jdwp.getIdManager, and I will post patches to update
gnu.classpath.jdwp.processor.* when this patch is finalized.

As noted in the ChangeLog entry, with this patch,
gnu/classpath/jdwp/id/JdwpIdFactory.java is deprecated.

Any better?
Keith

ChangeLog
2005-08-10  Keith Seitz  <address@hidden>

        * vm/reference/gnu/classpath/jdwp/VMIdManager.java: New file
        with example implementation of ID-management for JDWP back-end.
        * gnu/classpath/jdwp/id/JdwpIdFactory.java: Removed. Now part of
        VMIdManager.

jdwp-idmanager.patch
Description: Text Data