classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: Made PixelGrabber more robust


From: Mark Wielaard
Subject: Re: [cp-patches] FYI: Made PixelGrabber more robust
Date: Thu, 18 Aug 2005 22:56:45 +0200

Hi,

On Thu, 2005-08-18 at 15:41 +0200, Roman Kennke wrote:
>             public void run ()
>             {
> -             ip.startProduction (PixelGrabber.this);
> +              try
> +                {
> +                  ip.startProduction (PixelGrabber.this);
> +                }
> +              catch (Exception ex)
> +                {
> +                  ex.printStackTrace();
> +                  imageComplete(ImageConsumer.ABORTED);
> +                }
>             }
>           };

Why catch Exception and not Throwable? (You will miss notifying the
consumer when an Error is thrown). Why print the stack trace?

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]