[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[cp-patches] FYI: BasicScrollBarUI fix
From: |
Roman Kennke |
Subject: |
[cp-patches] FYI: BasicScrollBarUI fix |
Date: |
Thu, 27 Oct 2005 12:43:37 +0000 |
Hi,
I moved the code around a bit in BasicScrollBarUI. The initialization of
some fields has been done in the wrong methods. I confirmed that my
fixes are correct by some testcases that I committed to Mauve.
2005-10-27 Roman Kennke <address@hidden>
* javax/swing/plaf/basic/BasicScrollBarUI.java
(PropertyChangeHandler.propertyChange): If orientation property
changes, re-setup the UI.
(TrackListener.mouseReleased): Removed unused code.
(createIncreaseButton): Simply return a new instance without any
hacks.
(createDecreaseButton): Likewise.
(installComponents): Do not create the incrButton and decrButton
here, only install them on the ScrollBar.
(installDefaults): Also initialize the incrButton and decrButton
fields here.
(uninstallComponents): Added some null checks.
(uninstallDefaults): Uninstall border using the LookAndFeel
utility
method. Set incrButton and decrButton to null here.
(uninstallListeners): Added null checks.
(uninstallUI): Changed order of method calls. First uninstall
listeners then uninstallDefaults, because uninstallDefaults sets
the incrButton and decrButton fields to null, and
uninstallListeners
removes a listener from them. Avoids NPE.
/Roman
BasicScrollBarUI.diff
Description: Text Data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [cp-patches] FYI: BasicScrollBarUI fix,
Roman Kennke <=