Re: [cp-patches] Patch: Window fix

[Lillian Angel]

On Tue, 2005-11-01 at 23:18 +0000, Roman Kennke wrote:
> Hi,
> 
> Am 1.11.2005 schrieb "Lillian Angel" <address@hidden>:
> 
> >2005-11-01  Lillian Angel  <address@hidden>
> >
> >        * java/awt/Window.java
> >        (show): If pack is not called before show, the size of the
> >        window is often set to 0. This is now fixed.
> >
> 
> I reverted that patch, this is certainly wrong and I would want to avoid
> this to go into the release. If the size is not set explicitly and pack
> is not called, the Window size is set to its minimum. The attached
> little test program confirms this.
> 
> Lillian: If you are not 100% sure about things you change, especially in
> areas outside of your primary focus (== outside of Swing), please either
> back it up with a good mauve testcase and/or post it as RFC.
> 
> I suppose you have seen a bug in some app that has lead you to this
> change, what was the real problem that you patch was supposed to solve?

An app I tested (that fully works with the JDK), only calls show, not
pack. The JDialog is shown at the preferred size.

> 
> 2005-11-01  Roman Kennke  <address@hidden>
> 
>         * java/awt/Window.java
>         (show): Don't set size of the window here.