classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: Swing text fixlets


From: Mark Wielaard
Subject: Re: [cp-patches] FYI: Swing text fixlets
Date: Fri, 04 Nov 2005 15:42:22 +0100

Hi Roman,

On Fri, 2005-11-04 at 11:33 +0000, Roman Kennke wrote:
> This adds the getMinimumSize() method to the BasicTextUI and replaces a
> 'should never happen' comment with an assert statement.
> [...]
>      catch (BadLocationException e)
>        {
> -       // This should never happen.
> -       text = "";
> +        assert false : e.toString();
> +        text = "";
>        }

Please chain the exception before throwing the assert.

Thanks,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]