[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] RFC: native/jni/java-nio/gnu_java_nio_charset_iconv_Ic
From: |
Mark Wielaard |
Subject: |
Re: [cp-patches] RFC: native/jni/java-nio/gnu_java_nio_charset_iconv_IconvDecoder.c |
Date: |
Sat, 05 Nov 2005 13:53:37 +0100 |
Hi Ito,
On Sat, 2005-11-05 at 02:19 +0900, Ito Kazumitsu wrote:
> This path should fix the bug #24467
> (gnu_java_nio_charset_iconv_IconvDecoder.c treats normal bytes as invalid).
>
> 2005-11-04 Ito Kazumitsu <address@hidden>
>
> * native/jni/java-nio/gnu_java_nio_charset_iconv_IconvDecoder.c.orig
> (Java_gnu_java_nio_charset_iconv_IconvDecoder_decode):
> Do not check errno == EINVAL, which is a normal case.
I see EINVAL means part of a (possible valid) multibyte sequence was
read, while EILSEQ means a real invalid multibyte sequence. This looks
OK. Please commit. And please add the bug number to to commit message
and loose the .orig extension!)
Fixes bug #24467.
* native/jni/java-nio/gnu_java_nio_charset_iconv_IconvDecoder.c
(Java_gnu_java_nio_charset_iconv_IconvDecoder_decode):
Do not check errno == EINVAL, which is a normal case.
Thanks,
Mark
signature.asc
Description: This is a digitally signed message part