Re: [cp-patches] Fix for StAX stream writer

[Mark Wielaard]

Hi Chris,

On Sun, 2005-11-06 at 09:54 +0000, Chris Burdess wrote:
> Commited this patch to fix bug #24250.
> 
> 2005-11-06  Chris Burdess  <address@hidden>
> 
>         * javax/xml/stream/XMLStreamWriterImpl.java: Fixed handling of
>         namespaces when isPrefixDefaulting is set.

If you commit this while mentioning the PR number anywhere in the commit
message bugzilla will be automatically notified. For example:

2005-11-06  Chris Burdess  <address@hidden>

        Fixes bug #24250.
        * javax/xml/stream/XMLStreamWriterImpl.java: Fixed handling of
        namespaces when isPrefixDefaulting is set.

Then you don't have to update the bugzilla entry by hand because the
commit message will appear in the bug entry automatically. Magic! :)

> +  private int count = 0;
> [...]
> +  protected String createPrefix()
> +  {
> +    return "ns" + (count++);
>    }

Looks like this method can be private. Or are you thinking of an
subclass that overrides this method to provide different default
namespace prefixes? In that case please document that.

Please do also mention new methods in the ChangeLog entry in the future.
That makes looking up when something was introduced easier. See also:
http://www.gnu.org/software/classpath/docs/hacking.html#SEC9

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part