classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: MetalComboBoxEditor fixlet


From: David Gilbert
Subject: [cp-patches] FYI: MetalComboBoxEditor fixlet
Date: Mon, 07 Nov 2005 12:19:25 +0000
User-agent: Mozilla Thunderbird 1.0.7 (X11/20051026)

I committed this small fix to the MetalComboBoxEditor class. There is no need to recreate the editor component - it is created in the superclass constructor. Recreating it wipes out the custom setting for the number of columns in the JTextField. There is a new Mauve test to back this change:

2005-11-07  David Gilbert  <address@hidden>

        * javax/swing/plaf/metal/MetalComboBoxEditor.java
        (MetalComboBoxEditor): don't create new editor.

Regards,

Dave
Index: javax/swing/plaf/metal/MetalComboBoxEditor.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/javax/swing/plaf/metal/MetalComboBoxEditor.java,v
retrieving revision 1.3
diff -u -r1.3 MetalComboBoxEditor.java
--- javax/swing/plaf/metal/MetalComboBoxEditor.java     19 Oct 2005 13:46:02 
-0000      1.3
+++ javax/swing/plaf/metal/MetalComboBoxEditor.java     7 Nov 2005 12:03:52 
-0000
@@ -137,7 +137,6 @@
   public MetalComboBoxEditor()
   {
     super();
-    editor = new JTextField();
     editor.setBorder(new MetalComboBoxEditorBorder());
   }
   

reply via email to

[Prev in Thread] Current Thread [Next in Thread]