classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch: JTabbedPane fix


From: Lillian Angel
Subject: Re: [cp-patches] Patch: JTabbedPane fix
Date: Wed, 09 Nov 2005 17:05:33 -0500

I made a mistake in my last patch. In setComponent we do need to add and
remove the tab, but it is done differently now. Before it was adding the
tab with no title (therefore adding an empty tab), and removing it by
calling the wrong remove function. This is now fixed.

2005-11-09  Lillian Angel  <address@hidden>

        * javax/swing/JTabbedPane.java
        (setComponent): Tab should be inserted with a title, 
        and removed from the vector once set.
        (removeTabAt): Tab should only be removed from vector. 
        remove(Component) is called to remove the tab from the 
        JTabbedPane.
        (remove): Added call to the component. This function should 
        remove the component as well as the tab.


On Wed, 2005-11-09 at 16:29 -0500, Lillian Angel wrote:
> Another JTabbedPane fix.
> 
> 2005-11-09  Lillian Angel  <address@hidden>
> 
>         * javax/swing/JTabbedPane.java
>         (setComponent): No need to remove and add tab.
>         (remove): Fixed API documentation.
>         (remove): Fixed API documentation. Re-implemented according to 
>       API.
> 
> 
> On Wed, 2005-11-09 at 11:53 -0500, Lillian Angel wrote:
> > Made this fix because there were several problems when the layout mode
> > was set to SCROLLING. There are still some problems I am working on.
> > 
> > 2005-11-09  Lillian Angel  <address@hidden>
> > 
> >         * javax/swing/JTabbedPane.java
> >         (setComponent): Added check to prevent infinite loops.
> >         * javax/swing/plaf/metal/MetalTabbedPaneUI.java
> >         (createLayoutManager): Should call super here, so the layout
> >         is set properly depending on the layout mode.
> > 
> > _______________________________________________
> > Classpath-patches mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/classpath-patches
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

Attachment: patch.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]