Re: [cp-patches] RFC: WeakHashMap improvement

[Roman Kennke]

Hi,

Am Mittwoch, den 26.10.2005, 10:37 +0200 schrieb Roman Kennke:
> Hi,
> 
> Friedjof Siebert did some improvements on java.util.WeakHashMap that I'd
> like to check in. They are meant to improve reliability of this class by
> enabling the prove of a cast and the absence of a null-pointer.
> 
> 2005-10-26  Roman Kennke  <address@hidden>
> 
>         Reported by Friedjof Siebert  <address@hidden>
>         * java/util/WeakHashMap.java
>         (WeakEntrySet.Iterator.checkMod): Improved exception message.
>         (cleanQueue): Replaced null check with instanceof check to
>         prove correctness of cast at the same time.
>         (internalRemove): Removed redundant reads of buckets[slot] and
>         prev.next and added checks to ensure that no null pointer
>         exception may occur and that this can be proved automatically.

I committed the attached modified patch that does not replace the
null-check with an instanceof check.

2005-10-26  Roman Kennke  <address@hidden>

        Reported by Friedjof Siebert  <address@hidden>
        * java/util/WeakHashMap.java
        (WeakEntrySet.Iterator.checkMod): Improved exception message.
        (internalRemove): Removed redundant reads of buckets[slot] and
        prev.next and added checks to ensure that no null pointer
        exception may occur and that this can be proved automatically.

/Roman

patch.diff
Description: Text Data

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil