[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] Patch: GtkComponentPeer fix
From: |
Lillian Angel |
Subject: |
Re: [cp-patches] Patch: GtkComponentPeer fix |
Date: |
Tue, 15 Nov 2005 10:02:31 -0500 |
On Mon, 2005-11-14 at 17:16 -0500, Thomas Fitzsimmons wrote:
> On Mon, 2005-11-14 at 16:36 -0500, Lillian Angel wrote:
> > This fixes bug #24350. It is rather simple, the ChangeLog explains it
> > all.
>
> I think these test cases will only pass because of another bug where a
> window's position is not updated when it is moved. There are two
> distinct cases here, getting the location of a GtkComponentPeer and
> getting the location of a GtkWindowPeer. Can you try this patch
> instead:
>
> http://www.physto.se/~sven/pr24350.patch
>
> It handles both cases and gets the window's location in a way that
> should be more reliable for GDK.
Yes, Sven's patch works well.
I will revert my patch, and commit his.
Thanks,
Lillian