classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] RFC:Modifying example build system.


From: Meskauskas Audrius
Subject: [cp-patches] RFC:Modifying example build system.
Date: Thu, 17 Nov 2005 12:30:18 +0100
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)

This patch makes the system to compile, zip and install the CORBA examples as well. The CORBA examples were not installed because they were placed in the more nested folders that expected by the build script. The patch should fix the PR 24911.

The patch fixes problem in a primitive way, by adding additional folders. The true solution would be to process all example tree of the arbitrary depth and install all files, named "README" (probably any extension). The current patch may be, however, better than nothing, as the users say they have problems.

This is the first time I need to modify the build system. Surely I tested what I did, but somebody with good experience in Classpath building could briefly look at the patch.

2005-11-17  Audrius Meskauskas  <address@hidden>

* classpath/examples/Makefile.am
(EXAMPLE_JAVA_FILES): Extended by /*/*/*.java and /*/*/*/*.java.
(READMES): New category.
(ALL_EXAMPLE_FILES): Extended by READMES category.


Index: examples/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/examples/Makefile.am,v
retrieving revision 1.6
diff -u -r1.6 Makefile.am
--- examples/Makefile.am        5 Sep 2005 08:31:03 -0000       1.6
+++ examples/Makefile.am        17 Nov 2005 11:02:04 -0000
@@ -20,7 +20,7 @@
 endif
 
 # All our example java source files
-EXAMPLE_JAVA_FILES = $(srcdir)/gnu/classpath/examples/*/*.java
+EXAMPLE_JAVA_FILES = $(srcdir)/gnu/classpath/examples/*/*.java 
$(srcdir)/gnu/classpath/examples/*/*/*.java 
$(srcdir)/gnu/classpath/examples/*/*/*/*.java
 
 # The example C source files
 EXAMPLE_C_FILES = $(srcdir)/gnu/classpath/examples/*/*.c
@@ -34,8 +34,11 @@
 # the png icons we use in some of the examples.
 EXAMPLE_ICONS = $(srcdir)/gnu/classpath/examples/icons/*.png
 
+# The example specific README files.
+READMES = $(srcdir)/gnu/classpath/examples/CORBA/swing/README.html
+
 # All the files we find "interesting"
-ALL_EXAMPLE_FILES = $(EXAMPLE_JAVA_FILES) $(EXAMPLE_C_FILES) $(EXAMPLE_ICONS)
+ALL_EXAMPLE_FILES = $(EXAMPLE_JAVA_FILES) $(EXAMPLE_C_FILES) $(EXAMPLE_ICONS) 
$(READMES)
 
 # Some architecture independent data to be installed.
 example_DATA = $(EXAMPLE_ZIP) README

reply via email to

[Prev in Thread] Current Thread [Next in Thread]