classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: JComponent.setPreferredSize()


From: David Gilbert
Subject: [cp-patches] FYI: JComponent.setPreferredSize()
Date: Fri, 18 Nov 2005 00:37:57 +0000
User-agent: Mozilla Thunderbird 1.0.7 (X11/20051026)

This patch fixes a null pointer exception when I try to launch Findbugs. I've also backed this change up with some new Mauve tests:

2005-11-17  David Gilbert  <address@hidden>

        * javax/swing/JComponent.java
        (setPreferredSize): Check for null argument before making a copy.

Regards,

Dave
Index: javax/swing/JComponent.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/JComponent.java,v
retrieving revision 1.88
diff -u -r1.88 JComponent.java
--- javax/swing/JComponent.java 17 Nov 2005 23:54:10 -0000      1.88
+++ javax/swing/JComponent.java 18 Nov 2005 00:24:24 -0000
@@ -2564,7 +2564,10 @@
   public void setPreferredSize(Dimension pref)
   {
     Dimension oldPreferredSize = preferredSize;
-    preferredSize = new Dimension(pref);
+    if (pref != null)
+      preferredSize = new Dimension(pref);
+    else
+      preferredSize = null;
     firePropertyChange("preferredSize", oldPreferredSize, preferredSize);
   }
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]