Re: [cp-patches] FYI: RepaintManager fix

[Roman Kennke]

Am Samstag, den 19.11.2005, 19:09 +0100 schrieb Mark Wielaard:
> Hi Roman,
> 
> On Mon, 2005-11-14 at 12:52 +0000, Roman Kennke wrote:
> > +  /**
> > +   * The current repaint managers, indexed by their ThreadGroups.
> > +   */
> > +  static HashMap currentRepaintManagers;
> 
> Isn't this a potential memory leak? Maybe there are not many
> ThreadGroups in an application ever. But it might be wise to use a
> WeakHashMap here so that the entry disappears when the ThreadGroup is
> garbage collected.

This is fixed using the attached patch.

2005-11-21  Roman Kennke  <address@hidden>

        * javax/swing/RepaintManager.java
        (currentRepaintManagers): Use a WeakHashMap to avoid potential
        memory leak.
        (currentManager): Instantiate WeakHashMap instead of HashMap.
        (setCurrentManager): Instantiate WeakHashMap instead of HashMap.

/Roman

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil