Re: [cp-patches] RFC: BasicComboBoxUI minimum size caching

[Roman Kennke]

Hi Mark, hi list,

> Some more hacking on Free Swing (this stuff really seems to work for a
> lot of things now!). Emir uses something called the plastic theme. It
> seems to use the BasicComboBoxUI protected fields that cache the minimum
> size. So I implemented them and wrote some documentation on how I think
> they should behave. It just sets the cache when the minimumSize is
> requested and invalidates it in all the listeners that I thought were
> relevant. It seems to work for me (and the Free Swing Demo), but it
> would be nice if a Free Swing hacker could take a look.

Looks ok. Except that the cache is possibly invalidated a little too
often. I would think that the focus state doesn't change the
minimumSize. Also, the general propertyChange() invalidation is maybe
not good. But still ok to check in.

/Roman

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil