classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] RFC: BasicTabbedPaneUI paint null Icon?


From: Mark Wielaard
Subject: Re: [cp-patches] RFC: BasicTabbedPaneUI paint null Icon?
Date: Fri, 25 Nov 2005 14:58:56 +0100

Hi,

On Tue, 2005-11-22 at 01:03 +0100, Mark Wielaard wrote:
> This one is a little strange. Apparently the plastic laf overrides
> getIconForTab(int) and returns null in certain cases. But then it still
> calls paintIcon on it. I cannot find too much documentation on this, but
> this seems the correct thing to do:
> 
> 2005-11-21  Mark Wielaard  <address@hidden>
> 
>     * javax/swing/plaf/basic/BasicTabbedPaneUI.java (paintIcon): Only
>     paint icon when not null.
> 
> Comments?

Several people on irc said that they found it strange, but saw no
problem with it since it fixes a real current problem.

Committed,

Mark





reply via email to

[Prev in Thread] Current Thread [Next in Thread]