classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch: fixlet for Component focus event handling


From: Anthony Balkissoon
Subject: Re: [cp-patches] Patch: fixlet for Component focus event handling
Date: Wed, 30 Nov 2005 14:23:43 -0500

I wrote a better testcase and attached it to this bug report:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25165 . It shows the problem
was fixed incorrectly.  So I reopened the bug, and now this new patch
fixes it properly and removes the old fix.  I'll close the bug now.  

The problem with the old fix was that processFocusEvent (and, in fact,
processEvent) can be overridden from Component.  Doing so in a test case
showed that on the JDK these methods weren't called with FocusEvents
whose receiving Component and opposite Component were the same.  That
means it had to be tackled before it got to this stage.  That is what is
done now.

2005-11-30  Anthony Balkissoon  <address@hidden>

        Fixes bug #25165
        * java/awt/Component.java:
        (processFocusEvent): Don't check if focus opposite is the same as the
        receiving Component, this is now done in dispatchEventImpl.
        (dispatchEventImpl): Don't dispatch FocusEvents whose opposite 
        Components are the same.

On Wed, 2005-11-30 at 13:15 -0500, Anthony Balkissoon wrote:
> This patch fixes PR 25165.  If an attempt is made to give focus to a
> Component that already has it, no FOCUS_LOST and FOCUS_GAINED events
> should be processed.
> 
> 2005-11-30  Anthony Balkissoon  <address@hidden>
> 
>       * java/awt/Component.java:
>       (processFocusEvent): Don't dispatch events if the focus opposite is the
>       same as the receiving Component.
> 
> --Tony
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

Attachment: IgnoreFocusOppositesFix.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]