Re: [cp-patches] KerberosPrincipal - Try number two

[Mark Wielaard]

Hi Jeff,

On Mon, 2005-12-26 at 19:24 -0500, Jeff Bailey wrote:
> There are still several FIXMEs in the code, but I don't think any of
> them are barriers to adding the class to CVS.  Most of them are details
> that will be sorted out as the rest of the implementation is done and
> it's possible to actually test the code.

Thanks. Tom had two change requests. The only thing I would like to add
is that it is better to explicitly use getName() in both hashCode() and
equals(). equals() now uses toString(), which directly call getName(),
but that could get changed (as the FIXME suggests) in the future.

BTW. In general the toString() method should only be used for quick
human readable output (for debugging purposes) so the exact String
returned doesn't matter that much.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part