classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Patch: MetalLookAndFeel NPEs


From: Lillian Angel
Subject: [cp-patches] Patch: MetalLookAndFeel NPEs
Date: Tue, 03 Jan 2006 16:08:23 -0500

By running the mauve tests for this class, I noticed there were alot of
NPEs. I fixed these to check the theme and return null if the theme is
null. This is what Sun does.

2006-01-03  Lillian Angel  <address@hidden>

        * javax/swing/plaf/metal/MetalLookAndFeel.java
        (getDescription): Fixed to return the correct string.
        (getID): Likewise.
        (getName): Likewise.
        (getDefaults): Added check to avoid NPE.
        (getAcceleratorForeground): Likewise.
        (getAcceleratorSelectedForeground): Likewise.
        (getBlack): Likewise.
        (getControl): Likewise.
        (getControlDarkShadow): Likewise.
        (getControlDisabled): Likewise.
        (getControlHighlight): Likewise.
        (getControlInfo): Likewise.
        (getControlShadow): Likewise.
        (getControlTextColor): Likewise.
        (getControlTextFont): Likewise.
        (getDesktopColor): Likewise.
        (getFocusColor): Likewise.
        (getHighlightedTextColor): Likewise.
        (getInactiveControlTextColor): Likewise.
        (getInactiveSystemTextColor): Likewise.
        (getMenuBackground): Likewise.
        (getMenuDisabledForeground): Likewise.
        (getMenuForeground): Likewise.
        (getMenuSelectedBackground): Likewise.
        (getMenuSelectedForeground): Likewise.
        (getMenuTextFont): Likewise.
        (getPrimaryControl): Likewise.
        (getPrimaryControlDarkShadow): Likewise.
        (getPrimaryControlHighlight): Likewise.
        (getPrimaryControlInfo): Likewise.
        (getPrimaryControlShadow): Likewise.
        (getSeparatorBackground): Likewise.
        (getSeparatorForeground): Likewise.
        (getSubTextFont): Likewise.
        (getSystemTextColor): Likewise.
        (getSystemTextFont): Likewise.
        (getTextHighlightColor): Likewise.
        (getUserTextColor): Likewise.
        (getUserTextFont): Likewise.
        (getWhite): Likewise.
        (getWindowBackground): Likewise.
        (getWindowTitleBackground): Likewise.
        (getWindowTitleFont): Likewise.
        (getWindowTitleForeground): Likewise.
        (getWindowTitleInactiveBackground): Likewise.
        (getWindowTitleInactiveForeground): Likewise.

Attachment: patch.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]