classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] RFC: AX_CREATE_STDINT.m4


From: Mark Wielaard
Subject: Re: [cp-patches] RFC: AX_CREATE_STDINT.m4
Date: Wed, 04 Jan 2006 10:25:26 +0100

Hi Dalibor,

On Wed, 2006-01-04 at 03:56 +0100, Dalibor Topic wrote:
> the attached patch adds a generated header for C99 fixed-size integer 
> types that delegates to the underlying implementation (stdint.h, 
> inttypes.h) and/or creates typedefs for the missing types.
> 
> The patch uses the ax_create_stdint.m4 macro from Guido Draheim, taken 
> from ac-archive.sf.net, in the current CVS head version. It is licensed 
> under GPLWithACException. I've used it to fix the GNU Classpath build on 
> Cygwin, where fdlibm's mprec.h trying to redefine some C99 types lead to 
> compilation breakage.

Nice. Could you please add an URL to the original location in the
ax_create_stdint.m4 file itself so people can check there for updates
when something might fail on some weird platform.

> The patch passes make distcheck.

Thanks for trying that out.

> If the patch is accepted, I'll post a follow up patch, to clean up the 
> jni_md.h to use the corresponding C99 types, like I did in Kaffe a while 
> ago. Then the x86-linux specific jni_md.h file could go away.
>
> 2006-01-04  Dalibor Topic  <address@hidden>
> 
>       * configure.ac: Added AX_CREATE_STDINT_H
> 
>       * include/Makefile.am (DISTCLEANFILES): Remove config-int.h.
> 
>       * m4/ax_create_stdint_h.m4: New file.
> 
>       * native/fdlibm/mprec.h: Include config-int.h. Removed C99
>       typedefs. Removed stdint.h and inttypes.h includes.

Please check this in.

A cleanup for jni_md.h would be much appreciated by our non-x86
GNU/Linux friends :)

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]