classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] RFC: JMenuItem null accelerators


From: Anthony Balkissoon
Subject: Re: [cp-patches] RFC: JMenuItem null accelerators
Date: Wed, 04 Jan 2006 10:59:09 -0500

On Wed, 2006-01-04 at 00:08 +0100, Mark Wielaard wrote:
> Hi,
> 
> At various points we try to register a null KeyStroke with an InputMap.
> This gives some problems later on when InputMaps are copied because null
> entries aren't always expected. Does the following patch make sense?
> 

looks OK to me.

Tony

> 2006-01-03  Mark Wielaard  <address@hidden>
> 
>     * javax/swing/JMenuItem.java (configurePropertiesFromAction): Only
>     register keyboard action when accelerator is not null.
>     * javax/swing/plaf/basic/BasicMenuItemUI.java (propertyChange): Only
>     re-register accelerator if not null.
>     (installKeyboardActions): Only put accelerator in map when not null.
> 
> Cheers,
> 
> Mark
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches





reply via email to

[Prev in Thread] Current Thread [Next in Thread]