Re: [cp-patches] RFC: new VM interface for Socket impls

[Roman Kennke]

Hi,

I had to add various __attribute__((__unused__)) macros to make gcc
silent for all the klass parameters that are never used.

2006-01-04  Roman Kennke  <address@hidden>

        * native/jni/java-net/gnu_java_net_VMPlainSocketImpl.c,
        * native/jni/java-net/gnu_java_net_VMPlainDatagramSocketImpl.c:
        Added __attribute__((__unused__)) macros to avoid gcc warnings.

/Roman

Am 4.1.2006 schrieb "Roman Kennke" <address@hidden>:

>Hi Mark,
>
>Am 4.1.2006 schrieb "Mark Wielaard" <address@hidden>:
>
>>Hi,
>>
>>On Fri, 2005-12-16 at 16:48 +0100, Roman Kennke wrote:
>>> I have put together a new proposal for the VM interface for
>>> Plain(Datagram)SocketImpl. I incorporated most of Marks suggestions.
>>> Is this ok to check in?
>>
>>I think this is much cleaner then what we had. Thanks!
>>Please do check it in.
>
>Done, using the attached patch and this ChangeLog entry:
>
>2006-01-04  Roman Kennke  <address@hidden>
>
>        * vm/reference/gnu/java/net/VMPlainSocketImpl.java: New VM class.
>        * vm/reference/gnu/java/net/VMPlainDatagramSocketImpl.java:
>        New VM class.
>        * native/jni/java-net/gnu_java_net_VMPlainSocketImpl.c: New file.
>        * native/jni/java-net/gnu_java_net_VMPlainDatagramSocketImpl.c:
>        New file.
>        * native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c:
>        Removed.
>        * native/jni/java-net/gnu_java_net_PlainSocketImpl.c: Removed.
>        * native/jni/java-net/Makefile.am: Adjusted for new source files.
>        * gnu/java/net/PlainDatagramSocketImpl.java: Use new VM interface.
>        * gnu/java/net/PlainSocketImpl.java: Use new VM interface.
>        * include/gnu_java_net_PlainDatagramSocketImpl.h: Removed.
>        * include/gnu_java_net_PlainSocketImpl.h: Removed.
>        * include/gnu_java_net_VMPlainDatagramSocketImpl.h: New header
>file.
>        * include/gnu_java_net_VMPlainSocketImpl.h: New header file.
>
>BTW: the fix accidentally went in as two commits, sorry if that's
>inconvenient.
>
>> But I think we do want to make some small changes
>>still to the interface. In particular how we handle the SEND_LOCK,
>>timeouts (whether to use SO_TIMEOUT) and how to "cancel" a pending
>>accept like Guilhem already said. It is probably easier to change that
>>with this large patch out of the way when kaffe merges this in and/or
>>when we merge this into libgcj.
>
>Yes, these should also be fixed soon.
>
>/Roman