Re: [cp-patches] GNU Crypto and Jessie merge

[Mark Wielaard]

Hi Casey,

On Sun, 2005-12-25 at 17:06 -0800, Casey Marshall wrote:
> I've moved GNU Crypto and Jessie into my Classpath tree, approximately
> as I proposed to do earlier. The patch to Classpath, and a tarball of
> all the new files, are available from
> <http://metastatic.org/source/gnu-crypto-jessie.patch> and
> <http://metastatic.org/source/gnu-crypto-jessie.tar.gz>.
> This patch/tarball:
> 
>   - Adds GNU Crypto and Jessie under the packages gnu.javax.crypto and
> gnu.javax.net.ssl.
>   - Adds a `--disable-crypto' switch to configure, and based on that,
> uses either `standard.omit' (the default) or `no-crypto.omit' (which
> omits crypto providers).
>   - Updates `classpath.security' to add the new providers.

Nice. Thanks for doing this.
Sorry for the late reply. I am still moving houses and some of my
machines are in transit which makes patch review a bit harder. I hope to
finish the move next weekend.

> Does this otherwise look OK to commit?

Administrativia: The standard boilerplate at the top of each file should
be updated. Everything should state that it is copyright Free Software
Foundation, Inc. and that it is part of GNU Classpath (some files still
lits you as copyright holder and some have Jessie or GNU Crypto as
project name). And since we moved into the new year and this is a new
addition to GNU Classpath all files should be updated to add 2006 to
their copyright headers. (Please let me know if you need help updating
the headers, I should have some scripts to do that, but they are
probably on some machine that is in a box at the moment, sigh.)

> I know some have expressed
> concern over including crypto in Classpath, and wanted to know if the
> configure switch will suffice for them.

I am not sure the --disable-crypto part is enough to disable all
crypto[-hooks] so I would only include this if Anthony confirms this is
really what is needed to make the resulting binary "exportable" for him.
If not then I think we should not include it because people might rely
on that switch to purge all crypto things. (We already have crypto in
GNU Classpath since the 0.11 release, this only adds more and stronger
algorithms.)

I would like to see this go in soon so we can test it a bit before we do
a 0.20 release. It is mainly additional classes and new functionality so
it shouldn't break much I hope :) But please do feel free to merge it in
after 0.20 (somewhere around 14/15 Jan).

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part