Re: [cp-patches] installing logging.properties

[Mark Wielaard]

Hi Christian,

On Tue, 2005-07-19 at 21:27 +0200, Christian Thalinger wrote:
> Shouldn't the logging.properties file be installed instead of packaged
> into glibj.zip? Here is a patch for the resources Makefile. The file
> still added to glibj.zip, but this shouldn't be a problem.

According to LogManager the file is read from:

 * <li>If the system property <code>java.util.logging.config.class</code>
 *     is <em>not</em> set, the configuration parameters are read in from
 *     a file and passed to
 *     address@hidden #readConfiguration(java.io.InputStream)}.
 *     The name and location of this file are specified by the system
 *     property <code>java.util.logging.config.file</code>.</li>
 * <li>If the system property <code>java.util.logging.config.file</code>
 *     is not set, however, the contents of the URL
 *     "{gnu.classpath.home.url}/logging.properties" are passed to
 *     address@hidden #readConfiguration(java.io.InputStream)}.
 *     Here, "{gnu.classpath.home.url}" stands for the value of
 *     the system property <code>gnu.classpath.home.url</code>.</li>

So $(prefix)/jre/lib isn't the correct place for this file. It looks
like it should go into $(prefix) but that also isn't that nice.

> 2005-07-19  Christian Thalinger  <address@hidden>
> 
>       * resource/Makefile.am: Install logging.properties in
>       $(prefix)/jre/lib.
> 
> Index: resource/Makefile.am
> ===================================================================
> RCS
> file: /ahome/cacao/cacaocvs/cacao/src/classpath/resource/Makefile.am,v
> retrieving revision 1.6
> diff -u -3 -p -r1.6 Makefile.am
> --- resource/Makefile.am        5 Mar 2005 17:13:12 -0000       1.6
> +++ resource/Makefile.am        19 Jul 2005 19:20:58 -0000
> @@ -4,5 +4,8 @@ EXTRA_DIST = \
>                 orp-1.0.8.patch \
>                 orp-1.0.9.patch
>  
> +logging_DATA = java/util/logging/logging.properties
> +loggingdir = $(prefix)/jre/lib
> +
>  security_DATA = java/security/classpath.security
>  securitydir = $(prefix)/jre/lib/security

signature.asc
Description: This is a digitally signed message part