Re: [cp-patches] [generics] RFC: Genericize return type in PrinterStateReasons

[Andrew John Hughes]

On Sat, 2006-01-14 at 11:54 +0100, Wolfgang Baer wrote:
> Hi,
> 
> as this is my first patch for the generics branch I would like a
> comment if the patch is OK.
> 
> Also I would like to know if one should only genericize the API
> or also (as I did in this patch) genericize the method body and
> remove no longer needed stuff. I did this to get rid of a bunch
> of eclipse warnings but maybe this is not wanted at this stage
> as it might make merging harder.
> 
> Thanks,
> Wolfgang
> 
> 2006-01-14  Wolfgang Baer  <address@hidden>
> 
>       * javax/print/attribute/standard/PrinterStateReasons.java:
>       Remove no longer needed import of Iterator.
>       (printerStateReasonSet): Genericize return type and method body.
>       (put): Remove no longer needed casts.
> 
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

The patch looks fine to me; I think I already did some similiar edits on
this particular file when merging, so please make sure your patch is
against the latest version before committing.

Generally, I think these kind of edits are okay, but I'd save the
majority of it, where possible, to after the generics branch is
re-merged.  There are cases where it has to be done, and I also don't
see any problem with fixing the bits that are part of the API (this is
especially important for those who worship JAPI).  Additionally, it
could possibly catch the odd bug... though I've not seen it yet.

But, on the other hand, it does make merging HEAD a more slower, manual
process and also tends to be very tedious... I doubt you'd want to do
the lot :)

Thanks for your work on this -- it is appreciated.  As you may have
noticed, all the warnings you get by default from ecj are annoying!

Thanks again,
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)
attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

If you use Microsoft Office, support movement towards the end of vendor
lock-in:
http://opendocumentfellowship.org/petition/

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman

Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
public class gcj extends Freedom implements Java { ... }

signature.asc
Description: This is a digitally signed message part