Re: [cp-patches] [generics] FYI: New Instrumentation parameter to VMInstrumentationImpl.redefineClasses

[Nicolas Geoffray]

Andrew John Hughes wrote:

> > Instrumentation is a 1.5 package feature. It's not part of the 1.4 
> > specification. That's why
> > the files are only in the branch.
> >
> > Nicolas
> >
> >
> >    
>
> But the branch isn't for 1.5 features as such.  It's for stuff that will
> only compile when used with a compiler supporting the 1.5 features
> (generics, enums, annotations and a few bits of syntactic sugar).  So,
> if you can actually compile and run all the instrumentation stuff with a
> 1.4 suite, it should be on HEAD, IMHO.  At least, that was my
> understanding of this and why it's called a generics branch and not a
> 1.5 branch -- someone correct me if I'm wrong.  There are quite a few
> 1.5 package features on HEAD already.
>
>  
OK, I thought the generics branch was the equivalent of the 1.5 branch 
of sun. But if it's not the case, I have no problem commiting 
instrumentation code to HEAD. I do have one question though : the (sun) 
API of instrumentation has generics code (for example 
http://java.sun.com/j2se/1.5.0/docs/api/java/lang/instrument/ClassDefinition.html), 
does it make sense (and I'm OK if you think it does) to modify the API 
in order to fit for a non-generics code?

Nicolas