classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Re: JamVM stopped working today


From: Mark Wielaard
Subject: Re: [cp-patches] Re: JamVM stopped working today
Date: Tue, 17 Jan 2006 23:02:29 +0100

On Tue, 2006-01-17 at 22:44 +0100, Christian Thalinger wrote:
> On Tue, 2006-01-17 at 12:39 -0700, Tom Tromey wrote:
> > Twisti> --- native/jni/classpath/Makefile.am        24 Oct 2005 22:16:10 
> > -0000      1.6
> > [...]
> > Twisti>  AM_LDFLAGS = @CLASSPATH_MODULE@
> > 
> > This setting causes libclasspath to be built as a loadable module.
> > I don't think that is what we want.  I think we want a plain old
> > shared library.
> 
> Ok, when we remove that, should i commit the patch?

Please do! A working CVS is much better then a non-working/broken one.

Although I wish you hadn't also re-indented all the files. It was a bit
hard to see the actual changes you made (a ChangeLog entry would have
helped. Hint, hint...)

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]