classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: java-util adjustments for target/native


From: Mark Wielaard
Subject: Re: [cp-patches] FYI: java-util adjustments for target/native
Date: Thu, 19 Jan 2006 02:02:59 +0100

Hi Roman,

On Wed, 2006-01-18 at 10:19 +0000, Roman Kennke wrote:
> I checked in this adjustment for VMTimeZone.c to make use of the target
> native portability layer.
> 
> 2006-01-18  Roman Kennke  <address@hidden>
> 
>         * native/jni/java-util/java_util_VMTimeZone.c:
>         (Java_java_util_VMTimeZone_getSystemTimeZoneId): Rewritten
>         to use target native layer.
>         (jint_to_charbuf): Removed unneeded helper function.

I don't really like this change. Why was this necessary? As far as I can
see this just introduces another indirection through a macro and a
"generic" function without adding anything new for it (we don't seem to
have any other implementation then the current one, for embos or rtems
we could easily add a little ifdef and keep things as they are since
they don't implement this anyway.)

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]