[cp-patches] Re: Patch: More DefaultStyledDocument fixes

[Lillian Angel]

This small patch fixes several minor mauve regressions.


2006-01-23  Lillian Angel  <address@hidden>

        * javax/swing/text/DefaultStyledDocument.java
        (split): Should not use createLeafElement and 
        createBranchElement here. We should just instaniate the 
        LeafElements and BranchElements instead to avoid the case where 
        create*Element is overridden.



On Mon, 2006-01-23 at 11:15 -0500, Lillian Angel wrote:
> These fixes solve many mauve regressions for DefaultStyledDocument. 
> Tony's new mauve tests pointed out that we were recreating too many leaf
> elements.
> 
> 2006-01-23  Lillian Angel  <address@hidden>
> 
>         * javax/swing/text/DefaultStyledDocument.java
>         (insertFirstContentTag): Moved check outside of if-statement.
>         This should be checked before creating the new leaf element.
>         (insertFracture): Fixed check to prevent an NPE. The previous
>         leaf should only be recreated if it has been created by
>         insertFirstContentTag. Also, fixed up code: if the endOffset is
>         greater than the offset, then we need to create a temp leaf
>         as a place holder. Otherwise, the leaf elements should be
>         created normally.
>

patch.diff
Description: Text Data