classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: classpath ./ChangeLog java/lang/Character.java


From: Mark Wielaard
Subject: Re: classpath ./ChangeLog java/lang/Character.java
Date: 12 Jul 2002 23:23:21 +0200

Hi,

On Fri, 2002-07-12 at 23:06, Tom Tromey wrote:
>
>       2002-07-12  Jesse Rosenstock  <address@hidden>
>       
>       * java/lang/Character.java (toString(char)): Now static.

Which shows a bug in the implementation (which is different from the
libgcj one):

Found 1 semantic error compiling "../java/lang/Character.java":

  1542.     return new String(new char[] { value }, 0, 1, true);

Fixed as follows:


    2002-07-12  Mark Wielaard  <address@hidden>

        * java/lang/Character.java (toString(char)): use ch not value.

--- java/lang/Character.java    12 Jul 2002 21:06:18 -0000      1.29
+++ java/lang/Character.java    12 Jul 2002 21:21:26 -0000
@@ -1539,7 +1539,7 @@
   public static String toString(char ch)
   {
     // Package constructor avoids an array copy.
-    return new String(new char[] { value }, 0, 1, true);
+    return new String(new char[] { ch }, 0, 1, true);
   }

You did try to at least compile your fix before checking in didn't you?
That was a trick question because if you did do that you would have
complained that the javax.transaction.xa package was missing that is
needed by the new JDBC 3.0 stuff.

I am working on importing it from libgcj and adding some documentation.
Will add it to the Classpath tree soon till then just copy it from the
libgcj tree when needed.

Cheers,

Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]