classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] java.util.TimeZone doc/bogus GlobalRef.


From: C. Scott Ananian
Subject: [PATCH] java.util.TimeZone doc/bogus GlobalRef.
Date: Tue, 6 Aug 2002 15:37:10 -0400 (EDT)

The appended patch adds standard jni docs on method name and signature,
and removes an useless call to NewGlobalRef (the return value is never
used, much less stored across calls to the method) which would leak
a tiny bit of memory.
  --scott

mustard Pakistan FSF supercomputer $400 million in gold bullion Rijndael 
operation RUCKUS SEAL Team 6 Sabana Seca NRA SSBN 743 Iraq Ortega 
                         ( http://cscott.net/ )

Index: native/jni/java-util/java_util_TimeZone.c
===================================================================
RCS file: 
/cvsroot/classpath/classpath/native/jni/java-util/java_util_TimeZone.c,v
retrieving revision 1.2
diff -u -p -r1.2 java_util_TimeZone.c
--- native/jni/java-util/java_util_TimeZone.c   22 Jan 2002 22:27:02 -0000      
1.2
+++ native/jni/java-util/java_util_TimeZone.c   6 Aug 2002 19:23:56 -0000
@@ -62,6 +62,10 @@ exception statement from your version. *
  * initializer in java.util.TimeZone to create the default timezone
  * instance.  This is a key into the timezone table used by
  * that class.
+ *
+ * Class:     java_util_TimeZone
+ * Method:    getDefaultTimeZoneId
+ * Signature: ()Ljava/lang/String;
  */
 JNIEXPORT jstring JNICALL
 Java_java_util_TimeZone_getDefaultTimeZoneId(JNIEnv *env, jclass clazz)
@@ -101,8 +105,6 @@ Java_java_util_TimeZone_getDefaultTimeZo
   if (!retval)
     return(0);
  
-  (*env)->NewGlobalRef(env, retval);
-
   return(retval);
 }
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]