Patch: Eliminate GTK peer compiler warnings

[Thomas Fitzsimmons]

Hello,

GCC emits many warnings when it is compiling the GTK peers.  Most of the
warnings are for unused parameters which must be present to satisfy JNI
and GTK interface requirements (e.g. the JNIEnv pointer and GTK callback
parameters).

This patch flags these parameters as "unused" using GCC's __attribute__
extension.  It provides a fall-back for compilers that don't support
attributes.  The patch also contains fixes that eliminate all other
compiler warnings in the GTK peers.

Any objections?

Tom

2003-10-07  Thomas Fitzsimmons  <address@hidden>

        * gnu/java/awt/peer/gtk/GtkMenuItemPeer.java (setEnabled): Stub
        out.
        * jni/classpath/jcl.c [!__GNUC__]: Elide __attribute__.
        (JCL_free): Attach "unused" attribute to env parameter.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkImagePainter.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMainThread.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuItemPeer.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuPeer.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkPopupMenuPeer.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextComponentPeer.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkToolkit.c,
        jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c,
        jni/gtk-peer/gthread-jni.c: Attach "unused" attribute to unused
        parameters.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c:
        (initNativeState): Pass 0 as info argument to
        gtk_selection_add_target.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c:
        (setVisible, gtkFixedNew, gtkFixedPut, gtkFixedMove): Remove
        unused method implementations.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c
        (awt_event_handler): Add break statement after default label.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkImagePainter.c
        (drawPixels): Remove unused variable i.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuItemPeer.c
        (setEnabled): Remove method implementation.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuPeer.c
        (accel_attach): Call _gtk_accel_group_attach with G_OBJECT
        argument.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkPanelPeer.c (sr): Remove
        unused function.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkPopupMenuPeer.c
        (menu_pos): Assign TRUE to push_in.
        (setupAccelGroup): Call _gtk_accel_group_attach with G_OBJECT
        argument.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkScrollPanePeer.c
        (create): Remove unused variable layout.
        * jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c (create):
        Pass window_widget, rather than window, to
        gtk_widget_set_size_request.
        * jni/gtk-peer/gthread-jni.c (g_thread_jni_functions): Fill out
        structure initialization with NULL values.
        * jni/gtk-peer/gtkpeer.h [!__GNUC__]: Elide __attribute__.

attributes.diff
Description: Text Data