Re: FreeBSD build failure

[Archie Cobbs]

Michael Koch wrote:
> > > > > > The file native/target/generic/target_generic_file.h has this line:
> > > > > > 
> > > > > >     #define TARGET_NATIVE_FILE_FILEFLAG_SYNC O_SYNC
> > > > > > 
> > > > > > However, FreeBSD uses "O_FSYNC" rather than "O_SYNC", so the build 
> > > > > > of
> > > > > > Classpath on FreeBSD fails (is it just me?).
> > > > > 
> > > > > Well, I think classpath was not tested on FreeBSD for some month 
> > > > > (!!!).
> > > > > I've a patch that should solve your problems. Please test it and 
> > > > > report
> > > > > back.
> > > > 
> > > > Thanks, that should do it.
> > > 
> > > It should or it does ?
> > 
> > Sorry for the slow response.. I was intending to fully verify but haven't 
> > been able to due to cvs problems, etc. I will report to this list if it
> > does NOT work when/if I'm able to test it again.

OK, finally back to this issue.. I lost your original patch but
the one below (I think it's pretty much the same) fixes the build
problem.

Thanks,
-Archie

__________________________________________________________________________
Archie Cobbs     *    Halloo Communications    *     http://www.halloo.com


Index: target_generic_file.h
===================================================================
RCS file: 
/cvs-latest/classpath/classpath/native/target/generic/target_generic_file.h,v
retrieving revision 1.11
diff -u -r1.11 target_generic_file.h
--- target_generic_file.h       2 Nov 2003 15:51:19 -0000       1.11
+++ target_generic_file.h       11 Dec 2003 22:13:31 -0000
@@ -90,7 +90,13 @@
   #define TARGET_NATIVE_FILE_FILEFLAG_APPEND O_APPEND
 #endif
 #ifndef TARGET_NATIVE_FILE_FILEFLAG_SYNC
-  #define TARGET_NATIVE_FILE_FILEFLAG_SYNC O_SYNC
+  #if defined(O_FSYNC)
+    #define TARGET_NATIVE_FILE_FILEFLAG_SYNC O_FSYNC
+  #elif defined(O_SYNC)
+    #define TARGET_NATIVE_FILE_FILEFLAG_SYNC O_SYNC
+  #else
+    #define TARGET_NATIVE_FILE_FILEFLAG_SYNC 0
+  #endif
 #endif
 #ifndef TARGET_NATIVE_FILE_FILEFLAG_DSYNC
   #ifdef O_DSYNC