Re: Auditing source code

[Mark Wielaard]

Hi,

On Sun, 2003-12-21 at 15:25, Mark Wielaard wrote:
> [...]
> Which gives 212 files that differ.
> The same for kaffe gives 66 that differ.
> 
> We need to find explanations for these differences. I have not done that
> yet. But most differences seem easily explainable.
> [...]
> Which gives 127 file differences, not already in libgcj and kaffe, that
> need to be checked.
> 
> Again I have not done this, but most differences look like our normal
> updates between September 16 and December 1.

I started with these 127 files.
Attached is the audit log.
Didn't find anything suspicious.

There are lots of jni/gtk-peer changes which I only quickly checked for 
anomalies. We will replace these with the newer libgcj ones.

> The above ignores the external directory which contains a fresh
> GNU-JAXP. I don't know whether or not the ClasspathX hackers have been
> able to do a audit of that code yet.
> 
> I don't know how long the above will take me and help is appreciated.

Cheers,

Mark

AUTHORS -OK
ChangeLog -OK
HACKING -OK
NEWS -OK
configure.in -OK - But AC_INIT should say 0.07+cvs.

doc/www.gnu.org/include/macros.wml
doc/www.gnu.org/include/layout.wml
doc/www.gnu.org/faq/faq.wml
doc/www.gnu.org/faq/Makefile
doc/www.gnu.org/faq/.cvsignore
doc/www.gnu.org/downloads/tools.wml
doc/www.gnu.org/downloads/downloads.wml
doc/www.gnu.org/downloads/Makefile
doc/www.gnu.org/downloads/20020208.wml
doc/www.gnu.org/downloads/20010106.wml
doc/www.gnu.org/downloads/20001120.wml
doc/www.gnu.org/downloads/19990206.wml
doc/www.gnu.org/downloads/.cvsignore
doc/www.gnu.org/docs/docs.wml
doc/www.gnu.org/docs/Makefile
doc/www.gnu.org/stories.wml
doc/www.gnu.org/license.wml
doc/www.gnu.org/home.wml
doc/www.gnu.org/benchmarks.wml
doc/www.gnu.org/README
doc/www.gnu.org/Makefile
OK - Mostly new files created by Patrik.

doc/hacking.texinfo - OK. Updated Jikes RVM links.
doc/api/Makefile.am - OK. New gjdoc support, excluding external dir.

gnu/java/nio/Makefile.am
gnu/java/net/protocol/jar/Makefile.am
gnu/java/net/protocol/http/Makefile.am
gnu/java/net/protocol/file/Makefile.am
gnu/java/net/Makefile.am
OK - New/Moved classes. Classes themselves have been merged with libgcj.

gnu/java/lang/SystemClassLoader.java - OK. New import, spell fix.

gnu/java/lang/ClassLoaderHelper.java - OK. Explicit imports.

gnu/java/awt/peer/Makefile.am
gnu/java/awt/peer/gtk/Makefile.am
gnu/java/awt/image/Makefile.am
gnu/java/awt/Makefile.am
OK - New/Moved files. Except next two, alreadt merged with libgcj.

gnu/java/awt/BitwiseXORComposite.java
gnu/java/awt/doc-files/BitwiseXORComposite-1.png
OK - New files.

include/java_net_InetAddress.h 
include/java_lang_reflect_Array.h
OK - Regenerated header files.

include/gnu_java_net_PlainSocketImpl.h
include/gnu_java_net_PlainDatagramSocketImpl.h
OK - New/Moved header files.

include/gnu_java_awt_peer_gtk_GtkWindowPeer.h
include/gnu_java_awt_peer_gtk_GtkToolkit.h
include/gnu_java_awt_peer_gtk_GtkTextFieldPeer.h
include/gnu_java_awt_peer_gtk_GtkTextAreaPeer.h
include/gnu_java_awt_peer_gtk_GtkMenuItemPeer.h
include/gnu_java_awt_peer_gtk_GtkLabelPeer.h
include/gnu_java_awt_peer_gtk_GtkComponentPeer.h
include/gnu_java_awt_peer_gtk_GtkButtonPeer.h
include/gnu_java_awt_peer_gtk_GdkPixbufDecoder.h
include/gnu_java_awt_peer_gtk_GdkFontMetrics.h
OK - New or regenerated header files.

include/Makefile.am - OK added or moved header files.

include/.cvsignore - OK added Makefile and Makefile.in
(but building in src dir should probably be discouraged anyway.)

java/util/Makefile.am - OK. New Currency.java
java/text/Makefile.am - OK. New FormatCharacterIterator.java
java/nio/Makefile.am - OK. New ByteBufferHelper.java
java/net/Makefile.am - OK.
Moved Plain[Datagram]SocketImpl.java and SocketIn/OutputStream.java

java/lang/Thread.java - OK. Throw IllegalThreadStateException.

java/lang/Makefile.am - OK. Add Thread.java.

java/lang/Class.java - OK. Reeindentation.

java/awt/geom/doc-files/QuadCurve2D-5.png
java/awt/geom/doc-files/QuadCurve2D-4.png
java/awt/geom/doc-files/QuadCurve2D-3.png
java/awt/geom/doc-files/QuadCurve2D-2.png
java/awt/geom/doc-files/QuadCurve2D-1.png
java/awt/geom/doc-files/FlatteningPathIterator-1.html
java/awt/geom/doc-files/CubicCurve2D-5.png
java/awt/geom/doc-files/CubicCurve2D-4.png
java/awt/geom/doc-files/CubicCurve2D-3.png
java/awt/geom/doc-files/CubicCurve2D-2.png
java/awt/geom/doc-files/CubicCurve2D-1.png
OK - New files.

native/target/generic/target_generic_network.h - OK. Use fcntl FD_CLOEXEC.

native/target/generic/target_generic_misc.h
native/target/generic/target_generic_math_int.h
native/target/generic/target_generic_math_float.h
native/target/generic/target_generic_io.h
OK - Moved extern "C" decl and includes.

native/target/generic/target_generic_file.h - OK. Check filedescriptor >= 0.

native/target/generic/target_generic.h
native/target/Linux/target_native_network.h
native/target/Linux/target_native_misc.h
native/target/Linux/target_native_math_int.h
native/target/Linux/target_native_math_float.h
native/target/Linux/target_native_io.h
native/target/Linux/target_native_file.h
native/target/Linux/target_native.h
OK - Moved extern "C" decl and includes.

native/jni/java-nio/java_nio.c - OK. Moved from gnu.java.nio to java.nio.
native/jni/java-net/javanet.c - OK. Some classes moved to gnu.java.net. 

native/jni/java-net/java_net_InetAddress.c - OK. renamed getLocalHostName.

native/jni/java-net/gnu_java_net_PlainSocketImpl.c
native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
OK. New/Moved files.

native/jni/java-net/Makefile.am - OK. Mark moved files.

native/jni/gtk-peer/gtkpeer.h
native/jni/gtk-peer/gthread-jni.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkToolkit.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextFieldPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextComponentPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextAreaPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkScrollPanePeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkPopupMenuPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkPanelPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMenuItemPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkMainThread.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkLabelPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkImagePainter.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkClipboard.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkButtonPeer.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics2D.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGlyphVector.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkFontMetrics.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkClasspathFontPeerMetrics.c
native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkClasspathFontPeer.c
native/jni/gtk-peer/Makefile.am
OK. Compared to jni.gtk-peer from gcc.libjava.
The libjava version is not to different and all changes are improvements
that have recently been added on the libgcj side.
NOTE TO SELF.
Lots of new  NSA_SET_ macro use. Didn't know that actually worked with all VMs.
Some commented out g_print() calls which should just be removed.

native/jni/classpath/jcl.c - OK. Use and define __attribute__(x) /* nothing */

vm/reference/java/lang/Runtime.java - OK. New private runShutdownHooks.

vm/reference/java/lang/Makefile.am - OK. Removed Thread, added VMThread.

signature.asc
Description: This is a digitally signed message part