[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Small patch for java/text/AttributedString.java
From: |
Michael Koch |
Subject: |
Re: Small patch for java/text/AttributedString.java |
Date: |
Wed, 21 Jan 2004 14:50:21 +0100 |
User-agent: |
Mutt/1.3.28i |
On Wed, Jan 21, 2004 at 02:14:01PM +0100, Dalibor Topic wrote:
> Hi all,
>
> the attached patch fixes a small problem in AttributedString that
> prevented FOP from working with it on kaffe.
>
> OK to check in?
Some questions:
Does a mauve testcase exist for this ?
Wouldnt it be good to get rid of Hashtable usage in AttributedString
then at all ? There is only one other simple usage and Hashtable
features that are not in HashMap are not needed there anyway.
> + * @param value The value of the attribute, which may be null.
I think we omit the "which" everywhere else.
Michael