classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gtk-peer compile fixes for gcc-2.95


From: Tom Tromey
Subject: Re: gtk-peer compile fixes for gcc-2.95
Date: 05 Apr 2004 11:43:12 -0600
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>>>>> "Mark" == Mark Wielaard <address@hidden> writes:

Mark> The attached patch does that and enables -Wall for GNU Classpath.

Nice.  I skimmed it and it generally looks fine to me.

Mark> It fixes all issues found when compiling with -std=c89. Lots in the gtk
Mark> peers I am afraid. So please yell and scream if this is to intrusive. It
Mark> would be good if the gtk-peer stuff in libgcj was also compiled with
Mark> this flag.

I think it is a requirement, not just nice to have.  Otherwise we're
going to end up reintroducing code that isn't C89.

Here's an untested patch for the GUI branch.

Tom

Index: ChangeLog
from  Tom Tromey  <address@hidden>

        * Makefile.am (WARNINGS): Added -std=c89.

Index: Makefile.am
===================================================================
RCS file: /cvs/gcc/gcc/libjava/Makefile.am,v
retrieving revision 1.361.2.6
diff -u -r1.361.2.6 Makefile.am
--- Makefile.am 4 Mar 2004 17:31:02 -0000 1.361.2.6
+++ Makefile.am 5 Apr 2004 17:50:07 -0000
@@ -105,7 +105,7 @@
 
 GCC_UNWIND_INCLUDE = @GCC_UNWIND_INCLUDE@
 
-WARNINGS = -W -Wall
+WARNINGS = -W -Wall -std=c89
 ## We need _GNU_SOURCE defined for some Linux builds.  It doesn't hurt
 ## to always define it.
 AM_CXXFLAGS = -fno-rtti -fnon-call-exceptions $(THREADCXXFLAGS) \




reply via email to

[Prev in Thread] Current Thread [Next in Thread]