Re: JSpinner and javax.swing.Timer

[Thomas]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

IN the JSpinner I see a couple of variables that are called on the widget 
instead of on its model; probably with the idea that the widget forwards the 
call to the model.
For instance line 79 does a spinner.getValue()
since the spinner is stateful (due to the formattedtextfield) this should be 
spinner.getModel().getValue().

If you don't then overloading getValue (on jspinner) will generate strange 
results.

On Monday 24 May 2004 05:58, Ka-Hing Cheung wrote:
> Hi,
>
> I've been lurking around on #classpath a while ago and promised to
> implement JSpinner for classpath, and now finals are done and I finally
> finished it. Since the original javax.swing.Timer doesn't conform to SUN's
> javadoc nor even work, and JSpinner depends on it, so I fixed^Wrewrote it
> as well. Tested with sablevm and classpath cvs. Patch generated against
> classpath cvs.
>
> The first diff is for Timer and fix a couple components to call the right
> constructor. The rest are one diff for JSpinner and a couple added files.
>
> I've already sent off my email to FSF and am now waiting for their respond,
> so consider this email a solicitation for comments. I will resend the
> patches once the necessary paperworks are done.
>
> -khc

- -- 
Regards
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAsd9qCojCW6H2z/QRAv9kAKDwuLITE50iF9YycttAuiIrr8ObrwCfZVF6
X0ejJUu9gI+bK7GtyH7uTgA=
=lZn9
-----END PGP SIGNATURE-----