RE: [commit-cp] classpath ./ChangeLog lib/Makefile.am lib/gen-c...

[Jeroen Frijters]

Michael Koch wrote:
> > Please just check in the file. Requiring to run platform specific
> > scripts is not something that makes GNU Classpath more accessible.
> 
> We do this in other places too, e.g. gnu/classpath/Configuration.java.

That's the only place I'm aware of. The precedent for checking in
generated files is also there, the locale classes themselves are
generated and there are also the JNI header files.

> I will check it in later. 

Thanks.

BTW, Why do (some of) the generated files that have territories
hashtable define a new class for this, this is very wasteful and doesn't
really do anything useful? I must say that in general I'm not too
thrilled about this whole approach to using classes for storing this
information, a class file is a very inefficient way to store these kinds
of tables. Is there any need for these things to be classes? Would it be
possible to make the generated classes final, that would enable a small
codegen optimization (at least for me)?

BTW2, I don't mean to sound ungrateful. Thanks for doing this!

Regards,
Jeroen