[gnue] r8160 - in trunk/gnue-common/src/datasources: . drivers/Base

[reinhard]

Author: reinhard
Date: 2006-02-10 13:05:07 -0600 (Fri, 10 Feb 2006)
New Revision: 8160

Modified:
   trunk/gnue-common/src/datasources/GDataSource.py
   trunk/gnue-common/src/datasources/drivers/Base/RecordSet.py
   trunk/gnue-common/src/datasources/drivers/Base/ResultSet.py
Log:
Try to be more clear about what requery does.


Modified: trunk/gnue-common/src/datasources/GDataSource.py
===================================================================
--- trunk/gnue-common/src/datasources/GDataSource.py    2006-02-10 15:05:57 UTC 
(rev 8159)
+++ trunk/gnue-common/src/datasources/GDataSource.py    2006-02-10 19:05:07 UTC 
(rev 8160)
@@ -763,6 +763,10 @@
     requeries the top level master datasource of this datasource and all of
     that datasource's children.
 
+    Note that this method also updates the record status for all added,
+    modified and deleted records, so it has to be called even if the requery
+    feature of the datasource is not used.
+
     @param commit: indicate whether a commit was done since the call to
       L{postAll}.
     """

Modified: trunk/gnue-common/src/datasources/drivers/Base/RecordSet.py
===================================================================
--- trunk/gnue-common/src/datasources/drivers/Base/RecordSet.py 2006-02-10 
15:05:57 UTC (rev 8159)
+++ trunk/gnue-common/src/datasources/drivers/Base/RecordSet.py 2006-02-10 
19:05:07 UTC (rev 8160)
@@ -115,7 +115,8 @@
       and are not persistent.
     @param requery: If this is set to True, the RecordSet reqeries its values
       from the backend after posting, in case a backend trigger has changed
-      something.
+      something. This happens in the L{_requery} method that has to be called
+      after L{_post}.
     @param readonly: True if the RecordSet is read only. If set, an attempt to
       modify or delete this record raises an exception.
     @param details: Dictionary defining all details of this ResultSet, where
@@ -632,6 +633,9 @@
     This is called by L{ResultSet.requery} for each record that has been posted
     in the last L{ResultSet.post} call.
 
+    Note that this method also updates the record status, so it has to be
+    called even if the requery feature is not used.
+
     @param commit: True if a commit happened since the L{_post} call. If no
       commit has happened, the record will be requeried again after the
       following commit.

Modified: trunk/gnue-common/src/datasources/drivers/Base/ResultSet.py
===================================================================
--- trunk/gnue-common/src/datasources/drivers/Base/ResultSet.py 2006-02-10 
15:05:57 UTC (rev 8159)
+++ trunk/gnue-common/src/datasources/drivers/Base/ResultSet.py 2006-02-10 
19:05:07 UTC (rev 8160)
@@ -89,7 +89,8 @@
       and are not persistent.
     @param requery: If this is set to True, the ResultSet reqeries its values
       from the backend after posting, in case a backend trigger has changed
-      something.
+      something. This happens in the L{requery} method which has to be called
+      after L{post}.
     @param readonly: True if the ResultSet is read only. If set, an attempt to
       insert, modify or delete any record in this RecordSet raises an
       exception.
@@ -681,6 +682,11 @@
     operation should be committed, the L{Connection.commit} method can be
     called between post and requery.
 
+    Note that this method does not only requery changes from the database, but
+    it also updates the record status for all added, modified or deleted
+    records. So, requery must always be called after L{post}, even if the
+    requery feature is not used.
+
     @param commit: indicate whether a commit was run since the last L{post}
       call.