commit-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[hurd] 08/25: libfshelp: acquire references to control ports


From: Samuel Thibault
Subject: [hurd] 08/25: libfshelp: acquire references to control ports
Date: Mon, 24 Oct 2016 00:16:44 +0000

This is an automated email from the git hooks/post-receive script.

sthibault pushed a commit to branch upstream
in repository hurd.

commit 3f38f1b21cffcf669373baff46840ce0a7d902e5
Author: Justus Winter <address@hidden>
Date:   Fri Nov 20 12:46:56 2015 +0100

    libfshelp: acquire references to control ports
    
    * libfshelp/translator-list.c (translator_ihash_cleanup): Release reference.
    (fshelp_set_active_translator): Acquire reference
---
 libfshelp/translator-list.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/libfshelp/translator-list.c b/libfshelp/translator-list.c
index c87bbaa..e043a67 100644
--- a/libfshelp/translator-list.c
+++ b/libfshelp/translator-list.c
@@ -53,8 +53,7 @@ translator_ihash_cleanup (void *element, void *arg)
 
   if (translator->pi)
     ports_port_deref (translator->pi);
-  /* No need to deallocate translator->active, we only keep the name of
-     the port, not a reference.  */
+  mach_port_deallocate (mach_task_self (), translator->active);
   free (translator->name);
   free (translator);
 }
@@ -124,8 +123,10 @@ fshelp_set_active_translator (struct port_info *pi,
          t->pi = pi;
        }
 
-      /* No need to increment the reference count, we only keep the
-        name, not a reference.  */
+      if (MACH_PORT_VALID (t->active))
+       mach_port_deallocate (mach_task_self (), t->active);
+      mach_port_mod_refs (mach_task_self (), active,
+                         MACH_PORT_RIGHT_SEND, +1);
       t->active = active;
     }
   else

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/pkg-hurd/hurd.git



reply via email to

[Prev in Thread] Current Thread [Next in Thread]